Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(svg): duplicate id for background rect with multiple charts #1002

Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix(svg): duplicate id for background rect with multiple charts #1002

merged 3 commits into from
Nov 16, 2023

Conversation

Ovilia
Copy link
Member

@Ovilia Ovilia commented Apr 3, 2023 •
edited
Loading

Fix apache/echarts#18194 where the background rect of svg charts are all having the same id="0".

plainheart
plainheart reviewed Apr 3, 2023
View reviewed changes
src/svg/Painter.ts Outdated Show resolved Hide resolved
@Ovilia
Copy link
Member Author

Ovilia commented Nov 16, 2023

@plainheart I agree with you. Please review again. Thanks

@plainheart plainheart merged commit 2c11063 into master Nov 16, 2023
1 check passed
@plainheart plainheart deleted the fix-18194 branch November 16, 2023 14:01
@renovate renovate bot mentioned this pull request Mar 15, 2024
Closed
1 task
@X-oss-byte X-oss-byte mentioned this pull request May 25, 2024
Open
@chandraguptsharma1 chandraguptsharma1 mentioned this pull request Jul 17, 2024
Open
@junior junior mentioned this pull request Jul 26, 2024
Closed
@X-oss-byte X-oss-byte mentioned this pull request Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plainheart plainheart plainheart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] duplicate id=0 on multiple svg charts
2 participants
@Ovilia @plainheart